-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: allow concurrent artifact uploads #8437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richardgetz
wants to merge
13
commits into
aws:develop
Choose a base branch
from
richardgetz:rick/concurrent-uploads
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+481
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@richardgetz thank you for opening this PR! Looks like there are some failing tests, could you please check them? |
…sam-cli into rick/concurrent-uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/deploy
sam deploy command
area/package
sam package command
area/schema
JSON schema file
pr/external
stage/needs-triage
Automatically applied to new issues and PRs, indicating they haven't been looked at.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Why is this change necessary?
stacks. Allowing users to opt into parallel uploads lets them shorten the pre-deploy packaging phase when
bandwidth and CPU permit.
How does it address the issue?
S3/ECR uploads.
cache and guarding the ECR uploader’s login state.
What side effects does this change have?
remains the same (serial uploads) unless the flag/config setting is used.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.